fix(render): clamp vDomTopPad to zero when removing top rows - #4934
Closed
lukecotter wants to merge 1 commit into
Closed
fix(render): clamp vDomTopPad to zero when removing top rows#4934lukecotter wants to merge 1 commit into
lukecotter wants to merge 1 commit into
Conversation
In _removeTopRow, accumulated actual row heights can push vDomTopPad slightly negative, which sets a negative paddingTop and lets rendered content drift above the viewport. Clamp to zero after the adjustment.
This was referenced Aug 1, 2026
Contributor
Author
|
Folded into #4931, which now carries this fix unchanged as its own commit, so the four |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
_removeTopRow, accumulated actual row heights can pushvDomTopPadslightlynegative. That sets a negative
paddingTopand lets rendered content drift above theviewport.
Fix
Clamp
vDomTopPadto zero after the adjustment. One line.A note on test coverage
An e2e test written for this passed with and without the fix, so it was deleted
rather than kept as misleading coverage. The failure is a sub-pixel drift that the
existing harness cannot resolve; the reasoning is in the diff comment instead.
Performance
Neutral. 500k rows, K=5, medians: